Skip to content

Ignore maxWaitTime when CSOT is enabled. #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Ignore maxWaitTime when CSOT is enabled. #1744

wants to merge 6 commits into from

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin self-assigned this Jun 19, 2025
@katcharov katcharov marked this pull request as ready for review June 19, 2025 15:06
@katcharov katcharov requested a review from a team as a code owner June 19, 2025 15:06
@katcharov katcharov requested review from nhachicha, a team and stIncMale and removed request for a team and nhachicha June 19, 2025 15:06
stIncMale
stIncMale requested changes Jun 24, 2025
View reviewed changes
vbabanin added 2 commits June 26, 2025 17:52
@vbabanin
Use maxWaitTimeout consistently.
1fc6b7d 
Add JavaDoc to StartTime.
Shutdown executor properly.
@vbabanin
Adjust linebreaks.
820b131
@vbabanin vbabanin requested a review from stIncMale June 27, 2025 01:25
stIncMale
stIncMale requested changes Jul 25, 2025
View reviewed changes
...ync/src/test/functional/com/mongodb/client/AbstractClientSideOperationsTimeoutProseTest.java
Comment on lines +1094 to +1096
executor.shutdownNow();
//noinspection ResultOfMethodCallIgnored
executor.awaitTermination(MAX_VALUE, NANOSECONDS);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

executor may be null at this point, as it is initialized in the setUp method, and not in the constructor:

Suggested change
executor.shutdownNow();
//noinspection ResultOfMethodCallIgnored
executor.awaitTermination(MAX_VALUE, NANOSECONDS);
if (executor != null) {
executor.shutdownNow();
//noinspection ResultOfMethodCallIgnored
executor.awaitTermination(MAX_VALUE, NANOSECONDS);
}

@stIncMale
Copy link
Member

The last reviewed commit is 820b131.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stIncMale stIncMale stIncMale requested changes

Assignees

@vbabanin vbabanin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbabanin @stIncMale